Skip to content

[PR] Add is_valid_url? function#68

Open
LuchoTurtle wants to merge 3 commits intomainfrom
valid_url#64
Open

[PR] Add is_valid_url? function#68
LuchoTurtle wants to merge 3 commits intomainfrom
valid_url#64

Conversation

@LuchoTurtle
Copy link
Member

closes #64

This is a quick merge. Found this useful for small Elixir projects, thanks @ndrean 👌

@LuchoTurtle LuchoTurtle added enhancement New feature or request awaiting-review An issue or pull request that needs to be reviewed labels Nov 12, 2023
@codecov
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (335303d) to head (f329075).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        52    +2     
=========================================
+ Hits            50        52    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nelsonic
Copy link
Member

Agree that checking the validity of a URL is useful. ✅
Just have a quick question in the issue: #64 (comment)

If you need this function immeditately, please see: https://hexdocs.pm/link/Link.html#valid?/1
https://github.com/dwyl/link/blob/ca72089c0a56a0e1a96360ccba424b49b8165e3b/lib/link.ex#L143-L161 💭

@LuchoTurtle LuchoTurtle mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is_valid_url?

2 participants