Merge of pknowles 201706 #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgrind still detects some from readline's history and ncurses, but this may be expected behavior
some flags in HH_CONFIG should override others. this restores what was broken in a previous patch.
changes the minimal config to place the status in the prompt line defaults to highlight first match minor code cleanup
pknowles
commented
Jun 19, 2017
| if (patternChanged) { | ||
| patternChanged = false; | ||
| if (hstr->selectionSize > 0) { | ||
| selectionCursorPosition=0; |
Author
There was a problem hiding this comment.
After using this I think highlight selection should include the matching part of the pattern too.
pknowles
commented
Jun 19, 2017
| #define HH_VIEW_RANKING 0 | ||
| #define HH_VIEW_HISTORY 1 | ||
| #define HH_VIEW_FAVORITES 2 | ||
| #define HH_VIEW_FAVORITES 1 |
Author
There was a problem hiding this comment.
Strings in HH_VIEW_LABELS etc need to be updated to reflect these values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping some of this addresses the issues with the config parsing from my previous patch.
I'm not sure that I like the status-in-prompt idea I've tried (making it more similar to the regular bash ctrl-r), but there's a few other things that patch also cleans up. It might be good to split the minimal option into two.
Let me know what you think.