Closed
Conversation
Contributor
Author
|
Hi @AaronAtDuo Could you please review and share your feedback or any suggestions for improvement. |
|
Thanks @sandesh-as. @AaronAtDuo please merge this and push a release. |
|
@AaronAtDuo Can you please review this PR and lets us know if you need any help further? We are waiting for your response on this. |
|
@AaronAtDuo @zmilan @kenfox @yizshi Anyone can review this PR to make it compatible with PHP 8.5? |
Contributor
|
Fixed in #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.5 deprecated the curl_close() function because cURL handles are now objects (CurlHandle), and PHP’s garbage collector automatically frees them — calling curl_close() no longer does anything.
https://www.php.net/manual/en/migration85.deprecated.php#migration85.deprecated.curl
Motivation and Context
Leaving the call in the destructor would cause a “Deprecated” warning at runtime on PHP 8.5. Removing it avoids deprecation notices for users of the library on newer PHP versions.
How Has This Been Tested?
Types of Changes