Ensure consecutive request calls overwrite all the request options#17
Open
rubs33 wants to merge 1 commit intoduosecurity:masterfrom
Open
Ensure consecutive request calls overwrite all the request options#17rubs33 wants to merge 1 commit intoduosecurity:masterfrom
rubs33 wants to merge 1 commit intoduosecurity:masterfrom
Conversation
Contributor
|
Hi @rubs33, thank you for your contribution! We were previously notified of the DELETE issue and have already fixed it in this commit cdfa10e by unsetting CURLOPT_CUSTOMREQUEST on GETs and POSTs. In our testing this has already fixed the issue. Are you still experiencing this issue with the master or 1.0.3 version of this SDK? I agree that DuoAPI\FileRequester has a similar problem. Will will test and verify that fix. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the class DuoAPI\CurlRequester: since it is using the same curl resource (the property "ch") for multiple (consecutive) requests, it is supposed to overwrite all the curl options. Otherwise, a request with method DELETE followed by a request with method POST will fail.
The reason is that when a request with method DELETE is done, it sets the option CURLOPT_CUSTOMREQUEST with DELETE. But when the consecutive request with method POST is done, it only sets the option CURLOPT_POST with true, but CURLOPT_CUSTOMREQUEST is kept with the value from the previous request (DELETE).
To fix it, I prepared a change to ensure all the curl options are overwritten for each new request.
A similar problem may occur in the class DuoAPI\FileRequester, when a request is made using POST (with data to post), then a second request is made without any data to post.