feat(tui): allow navigating above launch directory#494
Merged
dundee merged 5 commits intodundee:masterfrom Feb 25, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 81.42% 81.54% +0.11%
==========================================
Files 49 49
Lines 5126 5179 +53
==========================================
+ Hits 4174 4223 +49
- Misses 816 820 +4
Partials 136 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Addressed the remaining Codecov patch gaps for tui/keys.go and pushed commit 144bc58. What changed:
Validation run locally:
Note: one parallel verification run hit a pre-existing Badger testdir lock contention in pkg/analyze; rerunning sequentially passed cleanly. |
Owner
|
Nice PR! I think we should put this behind a config option (could be probably just config file option, not the Gdu command flag) and default it to "disabled". |
Put the parent directory traversal feature behind a config file option (browse-parent-dirs) defaulting to disabled, as requested by the project maintainer. The option follows the existing config pattern (Flags struct -> getOptions -> UI setter) and is config-file only, not exposed as a CLI flag.
Contributor
Author
|
@dundee check |
dundee
approved these changes
Feb 25, 2026
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestMoveLeftRightto validate moving above the initial directory in an isolated temp working treeVerification
golangci-lint rungo test -v -covermode=count ./...go test -v -race -covermode=atomic -coverprofile=coverage.out ./...Fixes #481