Skip to content

Fix when a node has no childs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaguarondi wants to merge 2 commits into
base: version3
Choose a base branch
from
Open

Fix when a node has no childs #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17ac540
Fix when a node has no childs
david-bourgeois-cyanview Nov 22, 2025
681749d
Complied to the linter rule no-non-null-assertion
david-bourgeois-cyanview Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions src/client/ember-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,24 +264,28 @@ export class EmberClient extends EventEmitter {
throw new InvalidEmberResponseError(`getDirectory ${requestedPath}`);
}
} else if (node.getElementByPath(requestedPath) != null) {
this.logger?.log(ClientLogs.GETDIRECTORY_RESPONSE(node));
if (node.isStream()) {
const streamIdentifier = (node as Parameter).streamIdentifier;
const streamEntry = this._streams.getEntry(streamIdentifier);
if (streamEntry != null && streamEntry.value !== requestedPath) {
// Duplicate Stream Entry.
this.logger?.log(ClientLogs.DUPLICATE_STREAM_IDENTIFIER(streamIdentifier, requestedPath, streamEntry.value));
} else {
this.logger?.log(ClientLogs.ADDING_STREAM_IDENTIFIER(streamIdentifier, requestedPath));
this._streams.addEntry(
new StreamEntry(
streamIdentifier,
requestedPath
)
);
const resolved = node.getElementByPath(requestedPath);
if (resolved != null) {
this.logger?.log(ClientLogs.GETDIRECTORY_RESPONSE(resolved));

if (resolved.isStream && resolved.isStream()) {
const streamIdentifier = (resolved as Parameter).streamIdentifier;
const streamEntry = this._streams.getEntry(streamIdentifier);
if (streamEntry != null && streamEntry.value !== requestedPath) {
// Duplicate Stream Entry.
this.logger?.log(ClientLogs.DUPLICATE_STREAM_IDENTIFIER(streamIdentifier, requestedPath, streamEntry.value));
} else {
this.logger?.log(ClientLogs.ADDING_STREAM_IDENTIFIER(streamIdentifier, requestedPath));
this._streams.addEntry(
new StreamEntry(
streamIdentifier,
requestedPath
)
);
}
}
return resolved; // return the element, not the response root
}
return node; // make sure the info is treated before going to next request.
} else {
const nodeElements = node?.getChildren();
if (nodeElements != null &&
Expand Down