Skip to content

Conversation

@TennyZhuang
Copy link

@TennyZhuang TennyZhuang commented Dec 7, 2023

I can't find any reason to make the get_attrs method only available on Field<Value> but not Field<Type>.

It's very useful when we try to derive a method without self receiver, e.g.:

            mod schema {
                type Field;
                type VecField;

                trait Fields {
                    fn fields() -> VecField;
                }
            }

It is very likely that it was simply forgotten by #22.

@eupn Can you give some suggestions? Thanks!

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang changed the title Expose Field<Type>::get_attrs Expose Field<Type>::get_attrs,get_type Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant