Skip to content

fixed buffers in tests writing to expected value slice #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoCopter merged 1 commit into from
Dec 9, 2025
Merged

fixed buffers in tests writing to expected value slice #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions primitives_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ func TestUInt(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if n, err := ReadUInt(buff); err != nil {
t.Fatal(err)
} else if n != test.numb {
Expand Down Expand Up @@ -82,7 +83,8 @@ func TestByteStringLen(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if n, err := ReadByteStringLen(buff); err != nil {
t.Fatal(err)
} else if n != test.len {
Expand Down Expand Up @@ -116,7 +118,8 @@ func TestTextStringLen(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if n, err := ReadTextStringLen(buff); err != nil {
t.Fatal(err)
} else if n != test.len {
Expand Down Expand Up @@ -149,7 +152,8 @@ func TestArrayLen(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if n, err := ReadArrayLength(buff); err != nil {
t.Fatal(err)
} else if n != test.len {
Expand Down Expand Up @@ -182,7 +186,8 @@ func TestMapPairLen(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if n, err := ReadMapPairLength(buff); err != nil {
t.Fatal(err)
} else if n != test.len {
Expand Down
9 changes: 6 additions & 3 deletions simple_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ func TestBoolean(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if b, err := ReadBoolean(buff); err != nil {
t.Fatal(err)
} else if b != test.b {
Expand Down Expand Up @@ -47,7 +48,8 @@ func TestFloat32(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if f, err := ReadFloat32(buff); err != nil {
t.Fatal(err)
} else if f != test.f {
Expand Down Expand Up @@ -78,7 +80,8 @@ func TestFloat64(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.data)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.data)
if f, err := ReadFloat64(buff); err != nil {
t.Fatal(err)
} else if f != test.f {
Expand Down
6 changes: 4 additions & 2 deletions strings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ func TestByteString(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.cbor)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.cbor)
if data, err := ReadByteString(buff); err != nil {
t.Fatal(err)
} else if !reflect.DeepEqual(data, test.data) {
Expand Down Expand Up @@ -122,7 +123,8 @@ func TestReadTextString(t *testing.T) {

for _, test := range tests {
// Read
buff := bytes.NewBuffer(test.cbor)
buff := &bytes.Buffer{}
_, _ = buff.Write(test.cbor)
if data, err := ReadTextString(buff); err != nil {
t.Fatal(err)
} else if data != test.data {
Expand Down
Loading