Defines custom models for verticals #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
This PR defines the models for the different verticals we support in
pardnerat the moment. I opted to use Pydantic to define these models since it's flexible, leverages a lot of typing concepts already built into Python, and is easy to serialize/deserialize.As a reminder, we don't have plans to store any data in
pardner, that's the responsibility of the user of the library.Next up:
Verticalenum in codebase with references to newly created base vertical class #61BaseVerticalmodel rather thanAnyfor all Tumblr methods #62BaseVerticalmodel rather thanAnyfor all GroupMe methods #63BaseVerticalmodel rather thanAnyfor all Strava methods #64