Initial attempt at migrating from bootstrap 4 to 5#4
Draft
ian-noaa wants to merge 5 commits intodevelopmentfrom
Draft
Initial attempt at migrating from bootstrap 4 to 5#4ian-noaa wants to merge 5 commits intodevelopmentfrom
ian-noaa wants to merge 5 commits intodevelopmentfrom
Conversation
This results in a broken MATS UI. I've: - upgraded the "versionsFrom" to use the packages from meteor 2.3.5 instead of 1.4.1.1 (1.4.11?) - moved the daterangepicker from an atmosphere to npm dependency - moved bootstrap from an atmosphere to npm dependency
This could be improved but here's what I've tried
- Move to bootstrap's namespaced data-bs-toggle and data-bs-target
- Switch to bootstrap 5-style navbars
- Move the footer to use CSS grids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a broken MATS UI. I've: