Skip to content

Relax event message validation rules #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Dec 17, 2025
Merged

Relax event message validation rules #3394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/dstack/_internal/server/services/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,9 @@ def emit(session: AsyncSession, message: str, actor: AnyActor, targets: list[Tar
"""
if not targets:
raise ValueError("At least one target must be specified")
message = message.strip().rstrip(".").replace("\n", " ")
if not message:
raise ValueError("Message cannot be empty")
if message.strip() != message:
raise ValueError("Message cannot have leading or trailing whitespace")
if "\n" in message:
raise ValueError("Message cannot contain newlines")
if message.endswith("."):
raise ValueError("Message cannot end with a period")

logger.info(
"Emitting event: %s. Event targets: %s. Actor: %s",
Expand Down