-
Notifications
You must be signed in to change notification settings - Fork 208
[Feature]: Add JSON output option for CLI commands #3335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5e1932d
[Feature]: Add JSON output option for CLI commands #3322 (WIP)
peterschmidt85 7506e21
[Feature]: Add JSON output option for CLI commands #3322 (WIP)
peterschmidt85 2c97fc1
[Feature]: Add JSON output option for CLI commands #3322 (WIP)
peterschmidt85 724993a
[Feature]: Add JSON output option for CLI commands #3322 (WIP)
peterschmidt85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from typing import List | ||
|
|
||
| from dstack._internal.core.models.common import CoreConfig, generate_dual_core_model | ||
| from dstack._internal.core.models.gateways import Gateway | ||
| from dstack._internal.utils.json_utils import pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class GatewayCommandOutputConfig(CoreConfig): | ||
| json_dumps = pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class GatewayCommandOutput(generate_dual_core_model(GatewayCommandOutputConfig)): | ||
| """JSON output model for `dstack gateway` command.""" | ||
|
|
||
| project: str | ||
| gateways: List[Gateway] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| from typing import List, Literal, Optional | ||
|
|
||
| from dstack._internal.core.models.common import CoreConfig, generate_dual_core_model | ||
| from dstack._internal.core.models.gpus import GpuGroup | ||
| from dstack._internal.core.models.instances import InstanceOfferWithAvailability | ||
| from dstack._internal.core.models.resources import ResourcesSpec | ||
| from dstack._internal.utils.json_utils import pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class OfferRequirementsConfig(CoreConfig): | ||
| json_dumps = pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class OfferRequirements(generate_dual_core_model(OfferRequirementsConfig)): | ||
| """Profile/requirements output model for CLI commands.""" | ||
|
|
||
| resources: ResourcesSpec | ||
| max_price: Optional[float] = None | ||
| spot: Optional[bool] = None | ||
| reservation: Optional[str] = None | ||
|
|
||
|
|
||
| class OfferCommandOutputConfig(CoreConfig): | ||
| json_dumps = pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class OfferCommandOutput(generate_dual_core_model(OfferCommandOutputConfig)): | ||
| """JSON output model for `dstack offer` command.""" | ||
|
|
||
| project: str | ||
| user: str | ||
| requirements: OfferRequirements | ||
| offers: List[InstanceOfferWithAvailability] | ||
| total_offers: int | ||
|
|
||
|
|
||
| class OfferCommandGroupByGpuOutputConfig(CoreConfig): | ||
| json_dumps = pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class OfferCommandGroupByGpuOutput(generate_dual_core_model(OfferCommandGroupByGpuOutputConfig)): | ||
| """JSON output model for `dstack offer` command with GPU grouping.""" | ||
|
|
||
| project: str | ||
| requirements: OfferRequirements | ||
| group_by: List[Literal["gpu", "backend", "region", "count"]] | ||
| gpus: List[GpuGroup] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from typing import List | ||
|
|
||
| from dstack._internal.core.models.common import CoreConfig, generate_dual_core_model | ||
| from dstack._internal.core.models.runs import Run | ||
| from dstack._internal.utils.json_utils import pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class PsCommandOutputConfig(CoreConfig): | ||
| json_dumps = pydantic_orjson_dumps_with_indent | ||
|
|
||
|
|
||
| class PsCommandOutput(generate_dual_core_model(PsCommandOutputConfig)): | ||
| """JSON output model for `dstack ps` command.""" | ||
|
|
||
| project: str | ||
| runs: List[Run] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reservation can be specified via profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be
run_spec.configuration.reservation or run_spec.merged_profile.reservation?