One-sided fft; Current issues in consistency between one-sided and two-sided fft#14
Draft
katgonzalez17 wants to merge 23 commits intomainfrom
Draft
One-sided fft; Current issues in consistency between one-sided and two-sided fft#14katgonzalez17 wants to merge 23 commits intomainfrom
katgonzalez17 wants to merge 23 commits intomainfrom
Conversation
…demonstrate correctness
…nd back to physical properly
…w, will check with nusselt number and collect timing data
…ting corectness against (nusselt)
Owner
|
A few questions / suggestions:
It's possible that there is a subtle bug. It is also possible that some errors are accumulating naturally. Let's try to isolate the culprit. |
Collaborator
Author
|
Owner
|
Discrepancies of |
…ing to a debug file to determine at point in computations arrays begin to diverage
…al to conjg(i) to debug according to Hermitian redundancy
…ops in Fourier space; will print Nusselt number to compare against two_side_debug
… code with greater granularity
… discrepancies after calc_explicit(1)
…umber and printing Ti to isolate problem in calc_explicit
…_phi and T with Hermitian conjugate to tackle do loops in calc_explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the Nusselt number does change more significantly at larger grid sizes. I re-looked at my test script and noticed inconsistencies at 10^15, that (maybe?) these errors are amplified over multiple time steps, particularly for array sizes. Not sure what's going on, and am open to any and all suggestions for what to check out!
Attached is a photo of the Nusselt number over different time steps with a 1728 by 1377 grid.