fix: /cgnutools/include/$TARGET_TUPLE/c++/v1 for __config_site at LLV…#105
Open
takusuman wants to merge 1 commit intodslm4515:masterfrom
Open
fix: /cgnutools/include/$TARGET_TUPLE/c++/v1 for __config_site at LLV…#105takusuman wants to merge 1 commit intodslm4515:masterfrom
takusuman wants to merge 1 commit intodslm4515:masterfrom
Conversation
…M 1st stage Discovered this while building Copacabana's toolchain. Fixes dslm4515#72.
Owner
|
For the 2nd line edit, I think you forgot to use $TARGET_TUPLE instead of a architecture-specific one |
Contributor
Author
Sure, just one minute. |
Contributor
Author
|
Well, I think this also happens in other parts of the file, take a look: Lines 162 to 174 in 4de6732 That's why I used an architecture-specific example, and I think we could also assume that someone who's reading CMLFS knows that there are parts of the expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…M 1st stage
Discovered this while building Copacabana's toolchain. Fixes #72.