Skip to content

Wip device flow#348

Open
damienbfs wants to merge 11 commits intodevelopfrom
wip-device-flow
Open

Wip device flow#348
damienbfs wants to merge 11 commits intodevelopfrom
wip-device-flow

Conversation

@damienbfs
Copy link
Collaborator

No description provided.

@PaulineMauryL
Copy link
Member

PaulineMauryL commented Feb 13, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  client/lomas_client
  constants.py
  http_client.py 107-108, 124-130, 133, 174-178, 193-197
  client/lomas_client/models
  config.py
  client/lomas_client/tests
  test_integrations.py
  core/lomas_core/models
  config.py
  requests.py
  server/lomas_server
  app.py
  constants.py
  server/lomas_server/admin_database
  admin_database.py
  server/lomas_server/data_connector
  __init__.py
  data_connector.py
  server/lomas_server/dp_queries
  dp_querier.py
  dummy_dataset.py
  server/lomas_server/dp_queries/dp_libraries
  diffprivlib.py
  opendp.py
  smartnoise_sql.py
  utils.py
  server/lomas_server/routes
  middlewares.py
  routes_admin.py
  routes_dp.py
  utils.py
  server/lomas_server/tests
  test_api.py
  test_api_diffprivlib.py
  test_api_opendp_polars.py
  test_auth.py
Project Total  

The report is truncated to 25 files out of 33. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@damienbfs damienbfs marked this pull request as ready for review February 18, 2026 16:47
Comment on lines +57 to +59
return os.path.join(
tempfile.gettempdir(), f"lomas_{self.config.user_name}_{self.config.dataset_name}_token.json"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no pathlib ? :sadface:

Comment on lines +106 to +112
if not device_data.verification_uri_complete:
print(f"Go to: {device_data.verification_uri}")
print(f"Log in and authorize the Lomas Python client with this code {device_data.user_code}")
else:
print(f"Go to: {device_data.verification_uri_complete}")
print("Log in and authorize the Lomas Python client.")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rich.pretty for flex ?

Comment on lines +119 to +139
default = pkgs.dex-oidc.overrideAttrs (old: rec {
version = "c016300db963097d7a90eb010ae2f323dd54b0b7";
src = pkgs.fetchFromGitHub {
owner = "dexidp";
repo = "dex";
rev = "${version}";
sha256 = "sha256-COUhIxskcfnTF/TRmfb3IQ6Do+xdRV4xeNUspytc1Xw=";
};
patches = [
(pkgs.fetchpatch {
url = "https://github.com/dexidp/dex/commit/cccbebc146f95ddad890fd2307c9c0bf5497ecee.patch";
sha256 = "sha256-NsnqN+VeXi3NZ2zsp9KE5/9zqX9CioRrr0N313ZG3G0=";
})
];
vendorHash = "sha256-obnZ8DOCDSK2cqu6PNjAeQbkb24osRGwM6fq93WZpOc=";
passthru.tests = {
version = pkgs.testers.testVersion {
version = "${version}";
};
};
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants