check on input image to be rotated to best fit the current view orientation#3
Open
moovida wants to merge 1 commit intodsandler:masterfrom
Open
check on input image to be rotated to best fit the current view orientation#3moovida wants to merge 1 commit intodsandler:masterfrom
moovida wants to merge 1 commit intodsandler:masterfrom
Conversation
Owner
|
Hey, I took a look at this patch, and it would be more efficient to add a paintBitmap(Bitmap, Matrix) method so that we can just rotate it when drawing it for the first time. This way we don't have to duplicate the bitmap when loading it, which can use a ton of memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for the ratio of the loaded image (being it by load or by intent) against the current screen ratio. If necessary, it rotates the bitmap in order to best fit the drawing canvas.