-
-
Notifications
You must be signed in to change notification settings - Fork 142
Fix: Add pickle support for UnwrapFailedError (#2048) #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sobolevn
merged 10 commits into
dry-python:master
from
proboscis:issue-2048-add-pickle-support-for-unwrap-failed-error
Feb 27, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b8836db
Fix: Add pickle support for UnwrapFailedError (#2048)
proboscis 7c1b84c
Fix: Add noqa comment for __reduce__ method to fix flake8 warning
proboscis be2417c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e3002ac
Fix: Update CHANGELOG to add 0.24.1 section as per review
proboscis 00be682
Fix: Update test to move test logic outside of except block as per re…
proboscis 7e3681a
Fix: Clean up test code based on review feedback
proboscis 0258abf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b53843b
Fix: Remove redundant error variable initialization in test
proboscis b6a2e81
Update test_pickle_unwrap_failed_error.py
sobolevn d6ff6f7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
tests/test_primitives/test_exceptions/test_pickle_unwrap_failed_error.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import pickle # noqa: S403 | ||
|
|
||
| from returns.maybe import Nothing | ||
| from returns.primitives.exceptions import UnwrapFailedError | ||
| from returns.result import Failure | ||
|
|
||
|
|
||
| def test_pickle_unwrap_failed_error_from_maybe(): | ||
| """Ensures that UnwrapFailedError with Maybe can be pickled.""" | ||
| serialized = None | ||
| try: | ||
| Nothing.unwrap() # This will raise UnwrapFailedError | ||
| except UnwrapFailedError as error: | ||
| serialized = pickle.dumps(error) | ||
|
|
||
| deserialized_error = pickle.loads(serialized) # noqa: S301 | ||
| assert deserialized_error.halted_container == Nothing | ||
|
|
||
|
|
||
| def test_pickle_unwrap_failed_error_from_result(): | ||
| """Ensures that UnwrapFailedError with Result can be pickled.""" | ||
| serialized = None | ||
| try: | ||
| Failure('error').unwrap() # This will raise UnwrapFailedError | ||
| except UnwrapFailedError as error: | ||
| serialized = pickle.dumps(error) | ||
|
|
||
| deserialized_error = pickle.loads(serialized) # noqa: S301 | ||
| assert deserialized_error.halted_container == Failure('error') |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
0.24.1