Skip to content

Fixed an issue from PR #93#100

Open
BR0kEN- wants to merge 9 commits intodrupal-ukraine:masterfrom
BR0kEN-:issue-93
Open

Fixed an issue from PR #93#100
BR0kEN- wants to merge 9 commits intodrupal-ukraine:masterfrom
BR0kEN-:issue-93

Conversation

@BR0kEN-
Copy link

@BR0kEN- BR0kEN- commented Feb 4, 2016

@anpolimus
Copy link
Contributor

This pull request should be merged after my one in order not to break added features after merge conflicts fixes.

@anpolimus
Copy link
Contributor

#95

@anpolimus
Copy link
Contributor

@BR0kEN- Please, remove functions that are connected with github now.
GutHub features were implemented during first stage of ppdorg project when users were added manually.

Now, all github stuff is postponed for better concentration on d.org analysis.
We have a backlog of the tasks, you could work with.
https://github.com/drupal-ukraine/ppdorg/issues

@BR0kEN-
Copy link
Author

BR0kEN- commented Feb 4, 2016

@anpolimus, nothing connects to GH.

@anpolimus
Copy link
Contributor

@BR0kEN-
Lets start with steps for review of this pull request.
Could you please provide them?

<li>'.t('Active commenters').' : <strong>' . $active_by_comments_count . ' (' . number_format($active_by_comments_count/$all_user_count, 2)*100 . ')%</strong></li>
</ul>
</div>';
if ($all_user_count > 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevented division by zero (when no users in DB).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

@BR0kEN-
Copy link
Author

BR0kEN- commented Feb 4, 2016

Don't know what else I can describe. Suppose that code is understandable but, if not, you can ask me. :)

@anpolimus
Copy link
Contributor

Thx. Let me review that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, dont delete first parameter from _ppgetstat_api_call function.
In addition to the drupal.org we also have association api at the another domain
Also we will work to get localize.drupal.org api live and scan them too.

@anpolimus
Copy link
Contributor

@BR0kEN- Please, make your pull request sync with master.

@vzbot
Copy link

vzbot commented Feb 4, 2016

Build comment file:

Build site installed at http://ci-ukr.sanchiz.net/build-ppdorg-9


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci-ukr.sanchiz.net:8080/job/PPDORG_PR_BUILDER/9/

@BR0kEN-
Copy link
Author

BR0kEN- commented Feb 5, 2016

@Sanchiz, give me credentials to login to builds please.

// Remove expired cached pages.
_ppgetstat_cron_remove_cached_pages();

//Start users sync process with d.org
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpolimus, what you can suggest according to removal of these lines? I don't want reinstall the site and wait until history for 12 years will be obtained. This should be run only on production.

@BR0kEN-
Copy link
Author

BR0kEN- commented Feb 12, 2016

??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments