Optimise model downloads #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created list to handle previously downloaded files. Added tracking of files for potential multi printer support
Already had logic to check for the end / failure of a print, moved the temp file deletion to be a part of that
Combined download logic for ease of updating
Cleaned up remains of separated model retrieval logic. Putting temp files in OpenSpoolMan temp directory for easier/safer file clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Combined the sepearted model download logic into one path, for code reuse.
Optimised the temp file by making it more permanent to allow multiple functions to grab it without having to redownload. It has been named using the Printer IP and Printer name for future multiple printer support not causing temp file clashes.
Cleans up the temp file when the print finishes/fails.
Tested with P2S, AMS Pro 2 with LAN only mode.