Open
Conversation
added 22 commits
November 14, 2018 17:52
prepas
reviewed
Dec 5, 2018
|
|
||
| return TernaryNumber(1, std::stoul(numbers)); | ||
| unsigned int sum = 0; | ||
| for (auto rIter = numbers.rbegin(); rIter != numbers.rend(); ++rIter) |
Collaborator
There was a problem hiding this comment.
слишком большой шаг, один тест не мог привести к циклу с различными условиями и скорее всего на этом этапе тернарный оператор в 46 строке не полностью покрыт
prepas
reviewed
Dec 5, 2018
| ASSERT_EQ(0, ConvertTernaryNumbers("13")); | ||
| } | ||
|
|
||
| TEST(TernaryNumbers, Acceptence) |
Collaborator
There was a problem hiding this comment.
функция работает неправильно https://www.epochconverter.com/numbers/bin-oct-dec-hex
prepas
reviewed
Dec 5, 2018
| TEST(TernaryNumbers, MultipleNumberString) | ||
| { | ||
| ASSERT_EQ(3, ConvertTernaryNumbers("10")); | ||
| ASSERT_EQ(27, ConvertTernaryNumbers("10")); |
Collaborator
There was a problem hiding this comment.
3 было правильно, а 27 нет.
Неправильный тест повлиял на всю дальнейшую работу
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.