02 ternary numbers#5
Open
tolikheha wants to merge 8 commits intodriverdevteam:masterfrom
tolikheha:02_ternary_numbers
Open
02 ternary numbers#5tolikheha wants to merge 8 commits intodriverdevteam:masterfrom tolikheha:02_ternary_numbers
tolikheha wants to merge 8 commits intodriverdevteam:masterfrom
tolikheha:02_ternary_numbers
Conversation
added 8 commits
November 28, 2018 15:16
prepas
reviewed
Dec 5, 2018
|
|
||
| TEST (ternary_numbers, check_302) | ||
| { | ||
| EXPECT_EQ(302, convert("102012")); |
Collaborator
There was a problem hiding this comment.
первый сложный тест, антипаттерн Слишком сложный начальный тест
prepas
reviewed
Dec 5, 2018
|
|
||
| TEST (ternary_numbers, check_302) | ||
| { | ||
| EXPECT_EQ(302, convert("102012")); |
Collaborator
There was a problem hiding this comment.
непонятно зачем выносить строку
prepas
reviewed
Dec 5, 2018
| EXPECT_EQ(333, convert(g_ternary333)); | ||
| EXPECT_EQ(765, convert(g_ternary765)); | ||
| EXPECT_EQ(345, convert(g_ternary345)); | ||
| EXPECT_EQ(-1, convert("")); |
Collaborator
There was a problem hiding this comment.
требование в задании 0 в случае невалидности
prepas
reviewed
Dec 5, 2018
| } | ||
|
|
||
|
|
||
| TEST (ternary_numbers, acceptance) |
Collaborator
There was a problem hiding this comment.
нет негативного теста, если например будет больше 2 строке, судя по функции, она не отработает как нужно
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.