04 weather client#10
Open
tolikheha wants to merge 14 commits intodriverdevteam:masterfrom
tolikheha:04_weather_client
Open
04 weather client#10tolikheha wants to merge 14 commits intodriverdevteam:masterfrom tolikheha:04_weather_client
tolikheha wants to merge 14 commits intodriverdevteam:masterfrom
tolikheha:04_weather_client
Conversation
added 14 commits
January 10, 2019 16:00
prepas
reviewed
Jan 10, 2019
| results.insert(ParseWeather(server.GetWeather(date + ";03:00")).temperature); | ||
| results.insert(ParseWeather(server.GetWeather(date + ";09:00")).temperature); | ||
| results.insert(ParseWeather(server.GetWeather(date + ";15:00")).temperature); | ||
| results.insert(ParseWeather(server.GetWeather(date + ";21:00")).temperature); |
Collaborator
There was a problem hiding this comment.
нет рефакторинга, заполнение set дублируется
Collaborator
There was a problem hiding this comment.
увидел в конце рафакторинг
prepas
reviewed
Jan 10, 2019
| result += ParseWeather(response).windDirection; | ||
| response = server.GetWeather(date + ";15:00"); | ||
| result += ParseWeather(response).windDirection; | ||
| response = server.GetWeather(date + ";21:00"); |
Collaborator
There was a problem hiding this comment.
строки с временем 03:00, 09:00 и т.д. повторяются
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.