01 - Leap Year#19
Open
ZakKurasov wants to merge 28 commits intodriverdevteam:masterfrom
ZakKurasov:master
Open
01 - Leap Year#19ZakKurasov wants to merge 28 commits intodriverdevteam:masterfrom ZakKurasov:master
ZakKurasov wants to merge 28 commits intodriverdevteam:masterfrom
ZakKurasov:master
Conversation
mettizik
reviewed
Nov 8, 2018
| TEST(SplitTest, ReturnSameWordForOneWordSentence) | ||
| TEST(SplitTest, ReturnsNWordsForNWordsSentenceSentence) | ||
| { | ||
| EXPECT_EQ(std::vector<std::string>({"word"}), Split("word", " ")); |
Collaborator
There was a problem hiding this comment.
этот экспект должен идти отдельно, поскольку изолирует отдельный кейс отсутствия делимитера
| for (const std::string& word : words) | ||
| { | ||
| result.insert(std::make_pair(word, 1)); | ||
| if (result.find(word) != result.end()) |
Collaborator
There was a problem hiding this comment.
можно упростить за счёт оператора [] в std::map:
result[word] += 1;
Он сделает вставку, если элемента нет, а в противном случае возьмет существующий
Author
There was a problem hiding this comment.
А он проинициализирует вставленное значение нулем?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.