Open
Conversation
Krestol
reviewed
Oct 18, 2018
| const unsigned short g_linesInDigit = 3; | ||
| struct Digit | ||
| { | ||
| bool operator ==(const Digit& digit) |
Collaborator
There was a problem hiding this comment.
Разработана не по ТДД
Нужны были тесты
EXPECT_TRUE(s_digit0 == s_digit0)
EXPECT_FALSE(s_digit0 == s_digit1)
Krestol
reviewed
Oct 18, 2018
| unsigned long long ConvertDigit(Digit digit) | ||
| { | ||
| if (digit == s_digit0) | ||
| static const Digit allDigits[] = { s_digit0, s_digit1, s_digit2, |
Collaborator
There was a problem hiding this comment.
Сейчас этот массив должен был содержать только те цифры, на которые есть тесты
Krestol
reviewed
Oct 18, 2018
| result += ConvertDigit(digit) * std::pow(10, digitNumber); | ||
| } | ||
| return 000000000; | ||
| return result; |
Collaborator
There was a problem hiding this comment.
перед переходом к циклу нужен был тест на случай, когда цикл не выполнится ни разу.
Krestol
reviewed
Oct 18, 2018
| TEST(BankOcr, ConvertDisplay1) | ||
| TEST(BankOcr, ConvertDisplay0) | ||
| { | ||
| EXPECT_EQ(ConvertDisplay(s_displayAll0), 000000000); |
Collaborator
There was a problem hiding this comment.
странное ожидаемое значение "int 000000000"
Krestol
reviewed
Oct 18, 2018
| TEST(BankOcr, ConvertDisplay0) | ||
| { | ||
| EXPECT_EQ(ConvertDisplay(s_displayAll0), 000000000); | ||
| // EXPECT_EQ(ConvertDisplay(s_displayAll0), 000000000); |
Collaborator
There was a problem hiding this comment.
во время рефакторинга тесты должны быть работоспособные
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.