Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Conversation

@jtourkos
Copy link
Contributor

No description provided.

@jtourkos jtourkos requested a review from Copilot August 18, 2025 11:48
@railway-app
Copy link

railway-app bot commented Aug 18, 2025

🚅 Deployed to the events-processor-pr-68 environment in Drips App

Service Status Web Updated (UTC)
Event Processor ◻️ Removed (View Logs) Oct 25, 2025 at 9:09 am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements comprehensive support for handling deadline functionality in the codebase. The changes introduce new models, event handlers, and validation logic to manage deadline-based account relationships and their associated validation states.

Key Changes

  • Implementation of AccountSeenEventHandler to process deadline account events and trigger validation recalculation
  • Addition of DeadlineModel and AccountSeenEventModel for deadline data persistence
  • Integration of deadline validation checks into account validation logic across multiple account types

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils/validateLinkedIdentity.ts Added deadline validation to linked identity checks
src/utils/getAccountType.ts New utility for determining account types with database lookups
src/utils/checkIncompleteDeadlineReceivers.ts New utility for validating deadline receiver completeness
src/utils/accountIdUtils.ts Added support for RepoDeadlineDriver ID operations
src/models/DeadlineModel.ts New model for deadline data with proper indexes
src/models/AccountSeenEventModel.ts New event model for tracking account seen events
src/eventHandlers/AccountSeenEventHandler/ Complete event handler implementation for deadline processing
src/eventHandlers/SplitsSetEvent/setIsValidFlag.ts Refactored validation logic to include deadline checks
Various config/ABI files Added RepoDeadlineDriver contract support across networks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@railway-app railway-app bot temporarily deployed to events-processor-pr-68 August 18, 2025 11:50 Destroyed
@railway-app railway-app bot temporarily deployed to events-processor-pr-68 August 18, 2025 11:54 Destroyed
@railway-app railway-app bot temporarily deployed to events-processor-pr-68 August 18, 2025 11:57 Destroyed
@railway-app railway-app bot temporarily deployed to events-processor-pr-68 August 19, 2025 12:49 Destroyed
Base automatically changed from ecosystems to main August 22, 2025 10:42
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) September 2, 2025 09:01 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) September 2, 2025 09:51 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) September 8, 2025 13:56 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) September 16, 2025 09:47 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) September 29, 2025 09:52 Destroyed
Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work.

I skimmed large parts of this but did review the core logic additions. Didn't notice anything!

i only had one improvement idea. should we add a column like deadlineMet on the Deadlines table? And then when we process a repo account being claimed before the deadline we just set it to true. It'd avoid needing to query the underlying account to resolve a deadlineMet field on the API side, which I assume we'll want.

@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) October 2, 2025 11:36 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) October 7, 2025 10:44 Destroyed
@railway-app railway-app bot temporarily deployed to Event Processor (Drips App / events-processor-pr-68) October 7, 2025 10:52 Destroyed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants