-
Notifications
You must be signed in to change notification settings - Fork 1
Deadlines #68
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/core/splitRules.ts # tests/eventHandlers/SplitsSetEvent/processLinkedIdentitySplits.test.ts
|
🚅 Deployed to the events-processor-pr-68 environment in Drips App
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements comprehensive support for handling deadline functionality in the codebase. The changes introduce new models, event handlers, and validation logic to manage deadline-based account relationships and their associated validation states.
Key Changes
- Implementation of
AccountSeenEventHandlerto process deadline account events and trigger validation recalculation - Addition of
DeadlineModelandAccountSeenEventModelfor deadline data persistence - Integration of deadline validation checks into account validation logic across multiple account types
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/validateLinkedIdentity.ts |
Added deadline validation to linked identity checks |
src/utils/getAccountType.ts |
New utility for determining account types with database lookups |
src/utils/checkIncompleteDeadlineReceivers.ts |
New utility for validating deadline receiver completeness |
src/utils/accountIdUtils.ts |
Added support for RepoDeadlineDriver ID operations |
src/models/DeadlineModel.ts |
New model for deadline data with proper indexes |
src/models/AccountSeenEventModel.ts |
New event model for tracking account seen events |
src/eventHandlers/AccountSeenEventHandler/ |
Complete event handler implementation for deadline processing |
src/eventHandlers/SplitsSetEvent/setIsValidFlag.ts |
Refactored validation logic to include deadline checks |
| Various config/ABI files | Added RepoDeadlineDriver contract support across networks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
efstajas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work.
I skimmed large parts of this but did review the core logic additions. Didn't notice anything!
i only had one improvement idea. should we add a column like deadlineMet on the Deadlines table? And then when we process a repo account being claimed before the deadline we just set it to true. It'd avoid needing to query the underlying account to resolve a deadlineMet field on the API side, which I assume we'll want.
No description provided.