Skip to content

Added Variant SKU many places.#3

Open
djdarkbeat wants to merge 6 commits intodrhenner:masterfrom
djdarkbeat:master
Open

Added Variant SKU many places.#3
djdarkbeat wants to merge 6 commits intodrhenner:masterfrom
djdarkbeat:master

Conversation

@djdarkbeat
Copy link
Contributor

Added some variant SKU in many places to ease tracking of variants in cart and orders.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figaro looks good. It doesn't look like you applied it anywhere though. ❓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't commit the figaro file because I didn't want my API keys in the repo.

We could add one with some example keys though so people aren't' confused.

I faked out some keys in this file which you could commit.

Brian

Brian Loomis (208) 336-2586
http://www.customated.com

On Tuesday, November 19, 2013 at 8:48 AM, D. R. Henner wrote:

In Gemfile:

@@ -20,6 +20,7 @@ gem 'compass', '> 0.12.2' > gem 'compass-rails' > gem 'chronic' > gem 'dalli'#, '> 1.0.2' > +gem 'figaro'
Figaro looks good. It doesn't look like you applied it anywhere though.


Reply to this email directly or view it on GitHub (https://github.com/drhenner/stripe_commerce/pull/3/files#r7761082).

@pkamble
Copy link

pkamble commented Apr 10, 2014

I am using ROR-e framework to implement shopping cart.I found critical issue#
If user login with User ID =test@ror-e.com on Chrome browser and add 3 items to shopping cart for e.g. 3 items.
Now if user login with same User ID= test@ror-e.com on Firefox or IE or Safari browser and click on the shopping cart, It shows 0 items.It's suppose to show 3 items, since it's a same User ID.
So ROR-e framework is not storing items in shopping cart based on User,instead it is storing in session.
Please let me know if shopping cart is session based or user based or both.
Regards,
Pravin
917-514-0765
screen shot 2014-04-10 at 4 23 39 pm
screen shot 2014-04-10 at 4 25 09 pm

@drhenner
Copy link
Owner

It stores both depending on if you are logged in or not

I'll test it out but it should work
On Thursday, April 10, 2014 1:30 PM, mkrsqr notifications@github.com wrote:

I am using ROR-e framework to implement shopping cart.I found critical issue#
If user login with User ID =test@ror-e.com on Chrome browser and add 3 items to shopping cart for e.g. 3 items.
Now if user login with same User ID= test@ror-e.com on Firefox or IE or Safari browser and click on the shopping cart, It shows 0 items.It's suppose to show 3 items, since it's a same User ID.
So ROR-e framework is not storing items in shopping cart based on User,instead it is storing in session.
Please let me know if shopping cart is session based or user based or both.
Regards,
Pravin
917-514-0765


Reply to this email directly or view it on GitHub.

@pkamble
Copy link

pkamble commented Apr 10, 2014

Thanks David for response.I tested on Tonx.org, implementation of ROR-E and
it's working.
But it's not working on DEMO as well as on our implementation as well.
In my test case, I logged in first and then add items to cart.
Please let me know if i am making any mistake.

Also, we are planning got use your Stipe_Commerce and would like to make
payment $250.
Please let me know how can we do it.

On Thu, Apr 10, 2014 at 6:21 PM, D. R. Henner notifications@github.comwrote:

It stores both depending on if you are logged in or not

I'll test it out but it should work
On Thursday, April 10, 2014 1:30 PM, mkrsqr notifications@github.com
wrote:

I am using ROR-e framework to implement shopping cart.I found critical
issue#
If user login with User ID =test@ror-e.com on Chrome browser and add 3
items to shopping cart for e.g. 3 items.
Now if user login with same User ID= test@ror-e.com on Firefox or IE or
Safari browser and click on the shopping cart, It shows 0 items.It's
suppose to show 3 items, since it's a same User ID.
So ROR-e framework is not storing items in shopping cart based on
User,instead it is storing in session.
Please let me know if shopping cart is session based or user based or both.
Regards,
Pravin
917-514-0765

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-40150076
.

@drhenner
Copy link
Owner

Pravin,

I'll try to see what I can do to get this working on the weekend. My arm is getting out of a cast this weekend. (long story but broke it in a bike accident)

As for a payment, Lets chat outside of github. drhenner [at] ror-e.com

Dave

@drhenner
Copy link
Owner

@mkrsqr the merging carts logic should work now. I have not manually tested this yet but I added test and it appears to work as expected. If you have any issues ping me. I have to run to brunch!

@pkamble
Copy link

pkamble commented Apr 14, 2014

David,

I tested it manually couple of time and i can reproduce it on demo version
you deployed.
I attached screenshot on github.
It's strange, it works on www.tonx.org which is implementation ROR-e
commerce.

Regards,
Pravin

On Sun, Apr 13, 2014 at 2:46 PM, D. R. Henner notifications@github.comwrote:

@mkrsqr https://github.com/mkrsqr you merging carts logic should work
now. I have not manually tested this yet but I added test and it appears to
work as expected. If you have any issues ping me. I have to run to brunch!

Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-40315806
.

@drhenner
Copy link
Owner

I didn't deploy this to the demo. I'll get to that later if you want but first I need to do my taxes... 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants