Address code review feedback: remove backup file, fix lint errors, add documentation#95
Merged
drewsonne merged 3 commits intofix/winal-radix-correctionfrom Jan 2, 2026
Merged
Conversation
…ntation Co-authored-by: drewsonne <233054+drewsonne@users.noreply.github.com>
Co-authored-by: drewsonne <233054+drewsonne@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix winal radix correction with new test infrastructure
Address code review feedback: remove backup file, fix lint errors, add documentation
Jan 2, 2026
drewsonne
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from PR #94 regarding test code quality, unused imports, and missing documentation.
Changes
maya_date_correlations.json.bakfrom version controlto.be.true,to.be.null) with standard forms (to.equal(true),to.not.equal(null)) to avoid ESLint warningsfindCorrelationimports infull-date.spec.tsandwestern.spec.tseventGroups: { [event: string]: any[] }toRecord<string, CorrelationData[]>All tests passing. No security issues detected.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Note
Cleans up test suite and documentation while removing an accidental backup file.
src/__tests__/maya_date_correlations.json.bakto.be.true,to.be.null, etc.) with ESLint-friendly forms (to.equal(true),to.not.equal(null)) across specseventGroupstoRecord<string, CorrelationData[]>) and removes unusedfindCorrelationimports infull-date.spec.tsandwestern.spec.tscorrelation-validation.spec.tsexplaining the "winal radix correction" and its relevance to correlation constant validationWritten by Cursor Bugbot for commit b7020e4. This will update automatically on new commits. Configure here.