Skip to content

Comments

Address code review feedback: remove backup file, fix lint errors, add documentation#95

Merged
drewsonne merged 3 commits intofix/winal-radix-correctionfrom
copilot/sub-pr-94
Jan 2, 2026
Merged

Address code review feedback: remove backup file, fix lint errors, add documentation#95
drewsonne merged 3 commits intofix/winal-radix-correctionfrom
copilot/sub-pr-94

Conversation

Copy link
Contributor

Copilot AI commented Jan 2, 2026

Addresses code review feedback from PR #94 regarding test code quality, unused imports, and missing documentation.

Changes

  • Removed backup file: Deleted maya_date_correlations.json.bak from version control
  • Fixed lint errors: Replaced chai assertions (to.be.true, to.be.null) with standard forms (to.equal(true), to.not.equal(null)) to avoid ESLint warnings
  • Removed unused imports: Cleaned up findCorrelation imports in full-date.spec.ts and western.spec.ts
  • Fixed TypeScript errors: Changed eventGroups: { [event: string]: any[] } to Record<string, CorrelationData[]>
  • Added documentation: Documented winal radix correction purpose in test file:
/**
 * The winal radix correction refers to how 20‑day winals are handled when mapping
 * Long Count positions to a fixed day count (JDN) and then to Gregorian/Julian
 * calendar dates. Historically, small off‑by‑one errors in this radix handling
 * can shift whole correlation constants by one or more days.
 */

All tests passing. No security issues detected.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Note

Cleans up test suite and documentation while removing an accidental backup file.

  • Deletes backup dataset src/__tests__/maya_date_correlations.json.bak
  • Replaces Chai assertions (to.be.true, to.be.null, etc.) with ESLint-friendly forms (to.equal(true), to.not.equal(null)) across specs
  • Tightens types (e.g., eventGroups to Record<string, CorrelationData[]>) and removes unused findCorrelation imports in full-date.spec.ts and western.spec.ts
  • Adds documentation in correlation-validation.spec.ts explaining the "winal radix correction" and its relevance to correlation constant validation
  • No behavioral changes to core logic; tests remain green

Written by Cursor Bugbot for commit b7020e4. This will update automatically on new commits. Configure here.

Copilot AI and others added 2 commits January 2, 2026 17:18
…ntation

Co-authored-by: drewsonne <233054+drewsonne@users.noreply.github.com>
Co-authored-by: drewsonne <233054+drewsonne@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix winal radix correction with new test infrastructure Address code review feedback: remove backup file, fix lint errors, add documentation Jan 2, 2026
Copilot AI requested a review from drewsonne January 2, 2026 17:22
@drewsonne drewsonne marked this pull request as ready for review January 2, 2026 17:31
@drewsonne drewsonne merged commit 017f301 into fix/winal-radix-correction Jan 2, 2026
7 checks passed
@drewsonne drewsonne deleted the copilot/sub-pr-94 branch January 2, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants