Fix test structure: move forEach outside it block for proper test isolation#102
Merged
drewsonne merged 1 commit intofix/winal-radix-correctionfrom Jan 2, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on radix correction
Fix test structure: move forEach outside it block for proper test isolation
Jan 2, 2026
Co-authored-by: drewsonne <233054+drewsonne@users.noreply.github.com>
f1f2e9f to
84d4fb4
Compare
drewsonne
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses test antipattern where
forEachloop was nested inside a singleitblock, causing all assertions to run in one test case.Changes
forEachloop outsideitblock inGMT Correlation (584285) Validationtest suiteittest case with descriptive nameBefore/After
Before: Single test with loop inside
After: Individual test cases per data point
This provides proper test isolation, clearer failure reporting, and ensures all correlations are tested even if one fails.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Note
Refactors GMT correlation tests for proper isolation and clearer failures.
correlation-validation.spec.ts, move setup (directData,lcFactory,gmtCorr) to suite scopeitwith aforEachby generating individualitcases for the first five direct-source correlationsWritten by Cursor Bugbot for commit 84d4fb4. This will update automatically on new commits. Configure here.