Open
Conversation
Death111
requested changes
Apr 23, 2024
src/main/java/de/doubleslash/usb_led_matrix/view/AuthenticationView.java
Outdated
Show resolved
Hide resolved
src/main/java/de/doubleslash/usb_led_matrix/view/AuthenticationView.java
Outdated
Show resolved
Hide resolved
Death111
reviewed
Jun 7, 2024
| this.deviceCode.set(deviceCode); | ||
| } catch (IOException | InterruptedException e) { | ||
| LOG.error("Could not retrieve device code: ", e); | ||
| Thread.currentThread().interrupt(); |
Collaborator
There was a problem hiding this comment.
guess we should only interrupt, if interrupt exception was thrown. not also in case of IOException.
(same comment as was already resolved at another place)
Contributor
Author
There was a problem hiding this comment.
Is now only interrupted in the event of an interruption exception
Collaborator
There was a problem hiding this comment.
- extra ; present
- logging is different than in the other locations where u changed it. please do it consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.