-
Notifications
You must be signed in to change notification settings - Fork 230
[release/10.0.2xx] Source code updates from dotnet/razor #3449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.2xx
Are you sure you want to change the base?
[release/10.0.2xx] Source code updates from dotnet/razor #3449
Conversation
Diff: https://github.com/dotnet/razor/compare/191feab170b690f6a4923072d1b6f6e00272d8a7..52695a92b870d7d89ea37e6847f69930d10157c7 From: dotnet/razor@191feab To: dotnet/razor@52695a9 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
Diff: https://github.com/dotnet/razor/compare/52695a92b870d7d89ea37e6847f69930d10157c7..3522930f54e989f970f2deaeae30a248fab88227 From: dotnet/razor@52695a9 To: dotnet/razor@3522930 [[ commit created by automation ]]
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/razor/compare/3522930f54e989f970f2deaeae30a248fab88227..80cf79442ebb7ab9cbd9955c774504be55780c73 From: dotnet/razor@3522930 To: dotnet/razor@80cf794 [[ commit created by automation ]]
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/razor/compare/80cf79442ebb7ab9cbd9955c774504be55780c73..c4dd2233caf74ba61b1b718684b19ea8a7eb18ef From: dotnet/razor@80cf794 To: dotnet/razor@c4dd223 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/razor/compare/c4dd2233caf74ba61b1b718684b19ea8a7eb18ef..a31ef88815107ecbad86459b03d327fbba96bf16 From: dotnet/razor@c4dd223 To: dotnet/razor@a31ef88 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@davidwengier: It looks like dotnet/razor@ded0f0e is the cause of this build break. |
Diff: https://github.com/dotnet/razor/compare/a31ef88815107ecbad86459b03d327fbba96bf16..d4a50d974d9e9743d58d20b0e0413e78d813ecb0 From: dotnet/razor@a31ef88 To: dotnet/razor@d4a50d9 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
…10.0.2xx-ca97e402-82f6-41cb-a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/razor/compare/d4a50d974d9e9743d58d20b0e0413e78d813ecb0..855d2dd40ca42c837a92c6f1e45f178298dff48b From: dotnet/razor@d4a50d9 To: dotnet/razor@855d2dd [[ commit created by automation ]]
Diff: https://github.com/dotnet/razor/compare/09ee2b16afb243048ad6cc8c6f57391b39023b43..de6a167e1d7174af707201621b43c61932a3e166 From: dotnet/razor@09ee2b1 To: dotnet/razor@de6a167 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Build is green. I have no idea why. Stopping the Razor analyzer from building made the build start to fail with null annotation compiler errors, and VSTHRD002 errors in tests, which didn't affect us before, and don't affect us in main. Not sure if anyone from VMR can explain, but it's nothing I know how to deal with, that's for sure. Hopefully none of the million random changes I made cause any other issues 🤷♂️ |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Condition="'$(DotNetBuildSourceOnly)' != 'true'"> | ||
| <ItemGroup Condition="'$(DotNetBuildSourceOnly)' != 'true' and '$(DotNetBuildFromVMR)' != 'true'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks questionable...why do the analyzers not need to be built in the VMR?
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="5.0.0-2.25461.22" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.Common" VersionOverride="5.0.0-2.25461.22" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" VersionOverride="$(MicrosoftCodeAnalysisVersionForAnalyzerTests)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks questionable. Why is the tests property being used for the analyzers project?
Why would you not be able to reference a version of M.CA higher than the build compiler? I definitely can see that restriction at runtime, but at build time it doesn't make much sense to me. |
|
The analyzer in question is one for developers working in our repo, not one we deploy to the general public of Razor users, so "runtime" in this case is "a build of Razor.slnx", hence, this build. What I can't explain is why stopping that analyzer building caused the introduction of other analyzer and compiler warnings that weren't present two days ago. I only took the analyzer out of the build because it seemed like having the pre-built was less desirable, based on comments above. |
Diff: https://github.com/dotnet/razor/compare/de6a167e1d7174af707201621b43c61932a3e166..0440ae283c6976a75c6777a4ce4b7926d926a946 From: dotnet/razor@de6a167 To: dotnet/razor@0440ae2 [[ commit created by automation ]]
…a6c6-4fecaf98a68b
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
the build is green, can this be merged? |
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/razor/compare/c636be2de2bce8d50eec1a35b40f818a04af795c..153e938871d0ce897bad283fbf51bac21df23645 From: dotnet/razor@c636be2 To: dotnet/razor@153e938 [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
…2f6-41cb-a6c6-4fecaf98a68b
Diff: https://github.com/dotnet/razor/compare/153e938871d0ce897bad283fbf51bac21df23645..a8b3ccb884e497811fa31ef385f9486211bf88c5 From: dotnet/razor@153e938 To: dotnet/razor@a8b3ccb [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@mmitche @DustinCampbell this is green again but I don't understand if we want to merge |
|
|
No issues from me, I would love to merge this as I think (hope!) it unblocks some other things we have going on. @mmitche had concerns though, and definitely understands how things should work in the VMR better than me. I just threw spaghetti at the wall until the build went green :) |
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/razor
Diff the source with this PR branch