Issue16 #24
Issue16 #24
Conversation
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
mkdocs.yml
Outdated
| - "Inject Dependencies": v6/how-to/dependency-injection.md | ||
| - "Set Up CSRF": v6/how-to/csrf.md | ||
| - Security: | ||
| - "Security Observations": v6/security/security.md |
There was a problem hiding this comment.
Security Observations
can be
Security
There was a problem hiding this comment.
let's better use the term
"Basic Security"
as it is only a minimum, a starting point, a mandatory stuff
There was a problem hiding this comment.
- "Security Observations": v6/security/security.md
will be - "Basic Security Observations": v6/security/basic-security.md
docs/book/v6/security/security.md
Outdated
| composer development-status | ||
| ``` | ||
|
|
||
| - `Admin` ships with a `laminas/laminas-ci` integration, consider keeping it in your custom applications to ensure code quality. |
There was a problem hiding this comment.
add a link to lamians-ci , or to the article relatd to it from getlaminas.org
There was a problem hiding this comment.
There is no such repo laminas/laminas-ci.
We should probably add the reference to https://github.com/laminas/laminas-continuous-integration because that is the package used in our repo: https://github.com/dotkernel/admin/blob/6.0/.github/workflows/continuous-integration.yml#L11
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
| composer development-status | ||
| ``` | ||
|
|
||
| - `Admin` ships with a [Laminas Continuous Integration GitHub Action](https://github.com/laminas/laminas-continuous-integration-action), consider keeping it in your custom applications to ensure code quality. |
There was a problem hiding this comment.
| - `Admin` ships with a [Laminas Continuous Integration GitHub Action](https://github.com/laminas/laminas-continuous-integration-action), consider keeping it in your custom applications to ensure code quality. | |
| - `Admin` ships with a [Laminas Continuous Integration](https://github.com/laminas/laminas-continuous-integration-action) GitHub action, consider keeping it in your custom applications to ensure code quality. |
It's enough calling the link "Laminas Continuous Integration" and makes more sense leaving "GitHub action" after it.
There was a problem hiding this comment.
Maybe you should also mention that keeping the GHA in their repo makes sense only if the repo is public.
IIRC, (unless adding some token) the action will not run on private repos - @arhimede please confirm.
There was a problem hiding this comment.
Maybe you should also mention that keeping the GHA in their repo makes sense only if the repo is public. IIRC, (unless adding some token) the action will not run on private repos - @arhimede please confirm.
confirmed, is not working on private repos
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Added a new "security" section to the admin documentation.
I was unsure how much detail to add - should i add recommended config values, code examples?
Closes #16