Conversation
|
Hi, thanks for all great work! Please let me know when you are satisfied with it, then I will walk through it and comment (some things I like, some don't). |
|
Well, basically I think it's ready, except for tests. Ofc those could show something is broken, but the general shape should not change much even if they do.. |
|
Ok now I think I'm finished. There's always more that could be done, but that can be left to future PRs. Let me know after you've read through it.. |
|
I like
I don't think is needed
|
|
I can get rid of route prepending, or possibly add a configuration option to prepend instead of default append. Basically the only reason I added it in the first place was to work around a problem I had in one of my projects, and this was the easiest way (modify the thing I am trying to add instead of touching the stuff I have already written). I'll wait for @vojtech-dobes, I'm sure he'll have a lot to add. |
|
I really looking forward when this PR will be merged, but I think there still should be an option passing all parameters from template link to Generator and Provider(s)... |
Ok, this PR might be a little over the top, but I started playing with it and ended up with this. It's still not finished, I need to add more tests for Extension and especially Route, do some more prettying, clean up, and stuff like that. But I want to hear your opinions.
Summary of changes