Skip to content

Fixed relative StringTables indexes #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moofMonkey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed relative StringTables indexes #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions string_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,12 @@ func parseStringTable(buf []byte, numUpdates int32, name string, userDataFixed b
value := []byte{}

// Read a boolean to determine whether the operation is an increment or
// has a fixed index position. A fixed index position of zero should be
// has a relative index position. A fixed index position of zero should be
// the last data in the buffer, and indicates that all data has been read.
incr := r.readBoolean()
if incr {
index++
} else {
index = int32(r.readVarUint32()) + 1
if !r.readBoolean() {
index += int32(r.readVarUint32()) + 1
}
index++

// Some values have keys, some don't.
hasKey := r.readBoolean()
Expand Down