Skip to content

Conversation

@xitowzys
Copy link

@xitowzys xitowzys commented Nov 27, 2022

  1. When creating an optional parameter, it throws an error
    TypeError: Invalid variable type: value should be str, int or float, got None of type <class 'NoneType'>

  2. Support SteamingResponse

@xitowzys xitowzys changed the title If there is an optional parameter If there is an optional parameter and support SteamingResponse Nov 28, 2022
Comment on lines +10 to +11
homepage = "https://github.com/xitowzys-ISZF/fastapi-gateway"
repository = "https://github.com/xitowzys-ISZF/fastapi-gateway"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it changed from dotX12 to xitowzys-ISZF?

[tool.poetry]
name = "fastapi_gateway"
version = "0.0.3"
name = "fastapi_gateway_ultra"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also describe why you made the decision to change the name of the package and made a lot of edits about it, if it is appropriate and will bring some benefit, I can consider your suggestion, but for now it seems pointless to me.

@dotX12
Copy link
Owner

dotX12 commented May 12, 2023

And I think I understand, you made a fork and posted it on pypi under your own name, okay :)
I will review the proposal to add this PR this weekend. The work takes a lot of time in order to create open source projects...

@xitowzys
Copy link
Author

And I think I understand, you made a fork and posted it on pypi under your own name, okay :)
I will review the proposal to add this PR this weekend. The work takes a lot of time in order to create open source projects...

I apologize for the confusion that occurred here. I just want to continue developing this project further and was considering publishing it on PyPI with a different name under your fork. Also, I didn't realize that all subsequent changes would be reflected in Pull requests, as I'm still new to this process.

@dotX12
Copy link
Owner

dotX12 commented May 12, 2023

No big deal, it's because u opened a PR from your master to my master branch, so it merges all changes here.
image

@xitowzys
Copy link
Author

No big deal, it's because u opened a PR from your master to my master branch, so it merges all changes here.
image

Only now I noticed that. Thank you. I hope you will find time to review my previous changes 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants