Added FileNodeIterator for OpenCV 4.X to optimize vocabulary loading#69
Open
yhabib29 wants to merge 1 commit intodorian3d:masterfrom
Open
Added FileNodeIterator for OpenCV 4.X to optimize vocabulary loading#69yhabib29 wants to merge 1 commit intodorian3d:masterfrom
yhabib29 wants to merge 1 commit intodorian3d:masterfrom
Conversation
Author
|
Duplicate of #68, sorry I did not see the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenCV 4.0.0, the core module has been completely reimplemented in C++.
see https://github.com/opencv/opencv/wiki/ChangeLog#version400
Iterating throught
FileNodewithout iterator has become much more slower.To compare, see
test_filenodeprogram in branch yhabib29/DBoW2#dbg-opencv4.Average time for each loop iteration in function
loadinTemplatedVocabulary.h:1454:Tested on vocabulary
ORBvoc.yml(download link) with OpenCV 3.4.2 and 4.3.0 .