Beginnings of code update/overhaul replaced some constants with variables#2
Open
joeswhite wants to merge 4 commits intodooglus:masterfrom
Open
Beginnings of code update/overhaul replaced some constants with variables#2joeswhite wants to merge 4 commits intodooglus:masterfrom
joeswhite wants to merge 4 commits intodooglus:masterfrom
Conversation
updated to express config currency versus just saying "PP"
updated to express config currency versus just saying "PP"
updated to express config currency versus just saying "PP"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the beginning of a code overhaul. This pull request was created to notify the main developer of intent to overhaul code.
A few small code changes have been made. These changes are simply replacing some constants with variables so config currency is expressed and not hard coded.
These changes are only a few of the places where updates need to occur for this overhaul.