Skip to content

Conversation

@ddl-s-rodriguez
Copy link
Contributor

@ddl-s-rodriguez ddl-s-rodriguez commented Nov 14, 2025

What issue does this pull request solve?

The issue encountered is the inability to add essential parameters such as environmentId and externalVolumeMountIds in the method responsible for executing app_publish

What is the solution?

Add environmentId and externalVolumeMountIds

        if unpublishRunningApps:
            self.app_unpublish()
        app_id = self._app_id
        if app_id is None:
            # No App Exists creating one
            app_id = self.__app_create(hardware_tier_id=hardwareTierId)
        url = self._routes.app_start(app_id)
        request = {
            "hardwareTierId": hardwareTierId,
             "environmentId": environmentId,
             "externalVolumeMountIds": externalVolumeMountIds
        }
        response = self.request_manager.post(url, json=request)
        return response

Testing

Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.

e.g. "I ran an upgrade from 4.2 to 4.6".

  • Unit test(s)

Pull Request Reminders

References (optional)

Original PR with the contribution: #206

@ddl-s-rodriguez ddl-s-rodriguez requested a review from a team as a code owner November 14, 2025 18:09
@ddl-s-rodriguez ddl-s-rodriguez merged commit 960f4fb into master Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants