Skip to content

Remediating a previously reported DoS #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-emmon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remediating a previously reported DoS #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db95618
Remediating a previously reported issue
the-emmon Jan 25, 2022
3fec275
An update to the proposed DoS remediation
the-emmon Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/httpbeast.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,10 @@ proc bodyInTransit(data: ptr Data): bool =

if data.headersFinishPos == -1: return false

var trueLen = parseContentLength(data.data, start=0)
var headerContentLength = parseContentLength(data.data, start=0)

let bodyLen = data.data.len - data.headersFinishPos
assert(not (bodyLen > trueLen))
return bodyLen != trueLen
return bodyLen != headerContentLength

var requestCounter: uint = 0
proc genRequestID(): uint =
Expand Down Expand Up @@ -477,14 +476,6 @@ proc body*(req: Request): Option[string] =
pos .. ^1
].some()

when not defined(release):
let length =
if req.headers.get().hasKey("Content-Length"):
req.headers.get()["Content-Length"].parseInt()
else:
0
assert result.get().len == length

proc ip*(req: Request): string =
## Retrieves the IP address that the request was made from.
req.selector.getData(req.client).ip
Expand Down