Skip to content

httpbeast: option to set reusePort #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timotheecour wants to merge 7 commits into from
Closed

httpbeast: option to set reusePort #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39b93cf
httpbeast: option to set reusePort
timotheecour Apr 17, 2019
d6564d0
bump version
timotheecour Jun 27, 2021
64310f4
fix tests (use an Option to make code backward compatible)
timotheecour Jun 27, 2021
e08209b
ignore reusePort when running with multiple threads for now
timotheecour Jul 2, 2021
c316b87
Apply suggestions from code review
dom96 Jul 2, 2021
eca38f9
Update src/httpbeast.nim
dom96 Jul 2, 2021
804d42c
Update src/httpbeast.nim
dom96 Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpbeast.nimble
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Package

version = "0.3.0"
version = "0.4.0"
author = "Dominik Picheta"
description = "A super-fast epoll-backed and parallel HTTP server."
license = "MIT"
Expand Down
14 changes: 10 additions & 4 deletions src/httpbeast.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ type
domain*: Domain
numThreads: int
loggers: seq[Logger]
reusePort: bool
## controls whether to fail with "Address already in use".
## Setting this to false will raise when `threads` are on.

HttpBeastDefect* = ref object of Defect

Expand All @@ -63,14 +66,15 @@ const
proc initSettings*(port: Port = Port(8080),
bindAddr: string = "",
numThreads: int = 0,
domain = Domain.AF_INET): Settings =

domain = Domain.AF_INET,
reusePort = true): Settings =
Settings(
port: port,
bindAddr: bindAddr,
domain: domain,
numThreads: numThreads,
loggers: getHandlers()
loggers: getHandlers(),
reusePort: reusePort,
)

proc initData(fdKind: FdKind, ip = ""): Data =
Expand Down Expand Up @@ -317,7 +321,9 @@ proc eventLoop(params: (OnRequest, Settings)) =

let server = newSocket(settings.domain)
server.setSockOpt(OptReuseAddr, true)
server.setSockOpt(OptReusePort, true)
if compileOption("threads") and not settings.reusePort:
raise HttpBeastDefect(msg: "--threads:on requires reusePort to be enabled in settings")
server.setSockOpt(OptReusePort, settings.reusePort)
server.bindAddr(settings.port, settings.bindAddr)
server.listen()
server.getFd().setBlocking(false)
Expand Down