vi: Match cutscene functions (part 4) #2056
Merged
+347
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsgrimetime
force-pushed
the
vi-functions-4
branch
from
b1871c5 to
0cf69de
Compare
ribbanya
requested changes
Dec 30, 2025
Clean rebuild of vi-functions-4 branch without merge conflict markers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes implicit declaration warning for HSD_GObjProc_8038FD54. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- vi1202.h: Add forward declaration for vi1202_UnkStruct - vi1202.c: Change un_80321950 parameter to vi1202_UnkStruct* - vi1202.c: Convert raw pointer casts to M2C_FIELD macro usage - vi1202.c: Use HSD_GObj_Entities->fighters instead of raw offset - vi1202.c: Use cur->next instead of raw offset 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds crowd reaction function for knockback events. Determines category based on knockback magnitude thresholds and checks position bounds to trigger announcer voice lines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update declarations to match actual implementations: - vi0401.h: Add CharacterKind parameter for un_8031D030 - vi0402.h: Update un_8031D858_OnEnter parameter type - vi0501.h: Update un_8031D9F8 and fn_8031DD14 signatures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add stub markers for functions that are still unmatched to properly support NonMatching mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Implement fn_8031F600: camera animation proc with audio triggers - Add ef/efasync.h, ef/eflib.h, lb/lbarchive.h, pl/player.h includes to vi0402.c - Add gm/gm_1A45.h include to vi0401.c - Remove non-compiling assert call from vi0401.c - Update vi1101.h signature for fn_8031F600 - Add static float constants to vi1101.static.h 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- fn_8031F548: simple JObj animation callback - fn_8031F56C: camera render proc with shadow and erase 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Function was already implemented, just had leftover stub comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Simple JObj animation callback function. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Scene frame callback that checks button state and triggers transition. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Camera animation proc that checks specific frame values to trigger visual effects and audio cues at keyframes. Creates static header for file-local float constants. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
vi-functions-4
branch
from
99ea3f5 to
0ea90c6
Compare
- Add #include "gm/gm_1A45.h" to vi0501.c for gm_801A4B60 prototype - Remove fn_8031F56C from vi1101.h (function is static in implementation) - Mark vi0402.c as NonMatching (register allocation mismatch in un_8031D858_OnEnter) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ribbanya
previously approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
un_80321A00(vi1202)un_80321AF4(vi1202)un_803122D0_OnInit(100%)tyDisplay_8031C2EC(100%)un_80321EBC,un_8032201CimplementationsPart 4 of 4 for visual/cutscene module functions.
Test plan
🤖 Generated with Claude Code