vi: Match cutscene functions (part 2) #2054
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GALE01 (77946cc - 5f240ac)📈 Matched code: 47.71% (+0.04%, +1488 bytes) ✅ 14 new matches
📈 3 improvements in unmatched functions
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add implementations for two more vi1202.c functions: - un_80322298: Returns category based on float comparison with Fighter_804D6500 offsets - un_80322598: Complex branching with mpLib_80458868 and Fighter_804D6500 comparisons Updates header signatures for un_8032201C, un_80322298, un_80322598. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vi1201v1.c: - fn_8031FC30: CObj animation with frame checks - fn_8031FCBC: Frame counter with GObjPLink cleanup vi1201v2.c: - un_8032074C: JObj animation with gobj cleanup logic - un_803208F0: Shadow, CObj rendering, erase screen 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Button input check that triggers lb_800145F4 and gm_801A4B60 when specific button mask (0x1000) is pressed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CObj render setup with shadow, erase screen, and gxlink priority. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CObj animation function with frame-triggered visual events. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
vi-functions-2
branch
from
5b2f3ac to
280caa5
Compare
These functions are called with HSD_GObj* parameters in vi1202.c but were declared with UNK_PARAMS (no parameters) in the header. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Convert all instances of *(type*)((char*)ptr + offset) to use the M2C_FIELD(ptr, type*, offset) macro for consistency and readability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
un_80321CE8(vi1202.c)un_80322258(80.6%)un_80322298andun_80322598(vi1202.c)un_8031D698_OnFrame(vi0401.c)fn_8031F56C(vi1101.c)fn_8031EFE4(vi0801.c)Part 2 of 4 for visual/cutscene module functions.
Test plan
🤖 Generated with Claude Code