vi: Define CrowdConfig struct and rename Fighter_804D6500 #2053
+77
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsgrimetime
force-pushed
the
vi-functions-1
branch
from
bde0789 to
042978a
Compare
ribbanya
requested changes
Dec 31, 2025
itsgrimetime
added a commit
to itsgrimetime/melee
that referenced
this pull request
Jan 1, 2026
- Add vi1202_ViData struct for Fighter_804D6500 access - Replace raw pointer arithmetic with struct field access - Clean up un_80321950 and un_80321C70 to use struct types - Use named struct for vi1202_UnkStruct (forward declaration support) Addresses review feedback from PR doldecomp#2053. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
vi-functions-1
branch
3 times, most recently
from
f835e22 to
b9e272a
Compare
Fighter_804D6500 is not a Fighter - it's vi/cutscene related global data. Add proper struct type and replace M2C_FIELD macro calls with struct field access for better readability. - Add vi1202_ViData struct documenting fields at offsets 0x0-0x40 - Replace M2C_FIELD(Fighter_804D6500, ...) with struct access - Rename local 'fighter' variables to 'vdata' to reflect actual type - All function matches maintained at original levels Addresses PR review feedback about using proper struct types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move vi1202_ViData struct and Fighter_804D6500 extern to vi1202.h - Remove declaration from fighter.h and update definition in fighter.c - Replace all casts with direct struct field access 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Rename the global config pointer and struct to reflect its actual purpose - configuring crowd/announcer reactions during matches. Evidence for "Crowd" naming: - Symbol names from UnclePunch's Training Mode map (Feb 2019) - Functions at 0x80321900+ named CrowdSFXManager_* in that map - Audio function 0x8002411C named lbAudio_PlayCrowdSFX - Code behavior matches wiki descriptions of crowd gasps/cheers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add descriptive field names to CrowdConfig based on code analysis and runtime validation via Dolphin debugger: - kb_threshold_low/mid/high (100/130/160): knockback thresholds - recovery_y_high/mid/low (-10/-30/-80): recovery gasp Y thresholds - horiz_margin, blastzone_y_offset, fighters_near_blastzone, etc. - Restore missing functions un_80321294 and un_803224DC - Add required includes (baselib/aobj.h, baselib/cobj.h) - Fix un_80321294 declaration in header Field naming verified by setting breakpoints on: - 0x803224DC (Crowd_CheckForCrowdGaspUponHittingGround) - 0x80322598 (Crowd_CheckForCrowdGaspOnRecovery) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
vi-functions-1
branch
from
b9e272a to
fcf9a55
Compare
itsgrimetime
changed the title
itsgrimetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fighter_804D6500togCrowdConfig- this struct configures crowd/announcer SFX reactions, not fighter dataCrowdConfigstruct with documented field names based on code analysis and runtime validationvi1202.cto use named struct fields instead ofM2C_FIELDoffsetsEvidence for "Crowd" naming
CrowdSFXManager_*functions at 0x80321900+lbAudio_PlayCrowdSFXat 0x8002411CField documentation
kb_threshold_low/mid/highangle_min/max/multcheer_limitmax_gasp_counthoriz_marginrecovery_y_high/mid/lowfighters_near_blastzoneblastzone_y_offsetThreshold values validated via Dolphin debugger & memory inspection.