-
Notifications
You must be signed in to change notification settings - Fork 106
ty: Match trophy/toy functions (part 2) #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GALE01 (dc15c39 - d6b1cd9)📈 Matched code: 47.93% (+0.01%, +408 bytes) ✅ 6 new matches
💔 1 broken match
📈 1 improvement in unmatched functions
|
r-burns
reviewed
Dec 31, 2025
- Add lbaudio_ax.h and gm_1A45.h includes to toy.c - Add fn_80314504 prototype to tylist.h with baselib/forward.h - Add lb_00B0.h and baselib includes to tylist.c - Add missing includes to tydisplay.c 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Keep incoming changes for includes and decompiled functions: - toy.c: Add lbarchive.h and lbaudio_ax.h includes - tydisplay.c: Add gm_1A3F.h, gm_1A45.h includes and stub/function content - tylist.c: Add all includes, types, and function content 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The file contains stub markers (/// #fn_name) for unimplemented functions, causing undefined symbol errors when marked as Matching. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The file has stub markers for un_80317D80_OnEnter and un_803181BC, causing undefined symbol errors when marked as Matching. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
43cf0dd to
34ac8f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
un_8031B9A4_OnFrame(100%)tyFigupon_80314BE4(100%)un_80305C44(100%)Part 2 of 2 for trophy/toy module functions.
Test plan
🤖 Generated with Claude Code