ef: Match effect library functions (part 1) #2046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the implementation by accessing struct fields directly instead of using intermediate variables. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixed control flow to return early when efLib_804D64EC < 0x40 instead of continuing the loop. Added unused variables to match stack frame size. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Restructured control flow and fixed temp_r31->unk8 assignment to use pointer arithmetic instead of struct field access. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Report for GALE01 (acec241 - c23897f)📈 Matched code: 47.68% (+0.02%, +692 bytes) ✅ 5 new matches
📈 3 improvements in unmatched functions
|
The orig symlink was accidentally committed, breaking CI which tries to create its own symlink to /orig in the container. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The matched functions cause symbol offset misalignment. Reverting to NonMatching until all functions in the file are properly matched. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fn_8005DB70(100%)efAsync_8006730C(100%)efLib_8005BBB4(100%)efAsync_8006737C(93.3%)efLib_8005F454(100%)efLib_8005C1B4(100%)Part 1 of 3 for effect library functions.
Test plan
🤖 Generated with Claude Code