cm: Match 10 camera functions #2045
Open
+330
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GALE01 (ae5ac00 - 9579979)📈 Matched code: 47.91% (+0.05%, +1984 bytes) ✅ 7 new matches
📈 3 improvements in unmatched functions
|
Match the following camera functions: - Camera_8002E6FC (100%) - Sets camera target interest based on bitfield mode - Camera_8002E818 (100%) - Sets x341_b1_b2 = 2 and copies pos to pad_342[2] - Camera_8002E948 (100%) - Sets camera target interest from callback (mode 3) - Camera_8002EB5C (100%) - Sets camera target position from FOV with bitfield mode - Camera_8002EC7C (100%) - Similar to 8002EB5C but stores fov to 0x364 - Camera_8002ED9C (100%) - Takes float, converts to s16 and stores at 0x35E - Camera_8002F274 (100%) - Sets x341_b3_b4 = 1, copies transform.position to x35C.vec - Camera_8002B0E0 (100%) - Camera transform initialization - Camera_8002F9E4 (85.4%) - Pause mode camera initialization - Camera_8002FC7C (98.2%) - Camera state reset 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
cm-functions
branch
from
a584c8d to
044638b
Compare
sadkellz
reviewed
Jan 2, 2026
Address review feedback by moving the X35C_Bits struct from a file-local typedef with macro cast into the Camera struct's x35C union as an inline struct member. Also fix header signature mismatches for Camera_800293E0, Camera_800300F0, Camera_80030688, Camera_80030DF8, Camera_800310E8. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sadkellz
reviewed
Jan 3, 2026
Collaborator
sadkellz
left a comment
sadkellz
left a comment
There was a problem hiding this comment.
Left some more feedback that I missed the first pass.
- Convert pad_342 to x342_pad[2] + x344 union (s32/Vec3/cb) - Extend x35C union bits struct with s16 x2 at offset 2 - Replace pointer arithmetic with proper struct field access - Rename speculative parameter names to generic arg0/arg1: - Camera_8002EB5C, Camera_8002EC7C, Camera_8002ED9C - Camera_8002F9E4 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sadkellz
reviewed
Jan 3, 2026
Comment on lines
+143
to
+145
| u8 : 5; | ||
| u8 pad; | ||
| s16 x2; |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Camera_8002E6FCCamera_8002E948Camera_8002EB5CCamera_8002EC7CCamera_8002ED9C(100%)Camera_8002F274(100%)Camera_8002E818(100%)Camera_8002B0E0(100%)Camera_8002F9E4(85.4%)Camera_8002FC7C(71.8% → 98.2%)10 commits covering camera system functions.
Test plan
🤖 Generated with Claude Code