mp: Match island collision functions #2044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100% match achieved via decomp.me scratch qXzkT. Key matching insights: - Use goto-based loop structure with check-at-end pattern - Variable declaration order affects register allocation (prev_b before prev_a) - Use `end > v0` with forward goto instead of `end <= v0` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
100% match achieved via decomp.me scratch 0cY7A. Also updates: - mpIsland_80458E88_t struct to have correct pointer layout - mpIsland_8005B004 signature with 7 parameters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mpLib_80053ECC_Floor(100%)mpisland.hfunction signaturesmpIsland_8005AE1CmpIsland_8005B334, update struct layout5 commits covering island/map collision functions.
Test plan
🤖 Generated with Claude Code