ft: Match Popo (ftPp) and Kirby (ftKb) functions #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GALE01 (ae5ac00 - ac74ec9)📈 Matched code: 47.86% (+0.01%, +244 bytes) ✅ 3 new matches
📈 2 improvements in unmatched functions
|
Popo/Ice Climbers: - ftPp_SpecialS_80126EBC - Forward declarations for ftPp_1211 and ftPp_Init Kirby: - ftKb_Init_80130244 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
pr/ft-chara-misc
branch
from
7748d36 to
92c8f2b
Compare
r-burns
reviewed
Dec 31, 2025
Address PR review feedback by adding a float x84 member to the ftIceClimberAttributes struct instead of using pointer arithmetic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ftPp_SpecialS_80126EBCin Ice Climbers special side moveftKb_Init_80130244in Kirby initPart of the PR #2024 split.
Test plan
ninja🤖 Generated with Claude Code