Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/doit/apihw/api/controller/MemberController.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,9 @@ public void changePassword(@PathVariable Long memberId, @RequestBody AuthPasswor
}

// TODO : 자유 주제로 API를 추가로 구현해보세요.
@GetMapping("/members/birthday")
public List<MemberResponse> findAllBirthdayMembers() {
return memberService.findTodayBirthdayMember();
}

}
13 changes: 7 additions & 6 deletions src/main/java/doit/apihw/api/service/AuthService.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
package doit.apihw.api.service;

import doit.apihw.api.controller.dto.AuthLoginRequest;
import doit.apihw.api.controller.dto.AuthLoginResponse;
import doit.apihw.api.controller.dto.AuthPasswordChangeRequest;
import doit.apihw.api.controller.dto.AuthSignUpRequest;
import doit.apihw.api.controller.dto.*;
import doit.apihw.domain.member.Member;
import doit.apihw.domain.member.MemberRepository;
import lombok.RequiredArgsConstructor;
Expand Down Expand Up @@ -52,11 +49,15 @@ public AuthLoginResponse signUp(AuthSignUpRequest request) {
// TODO : 로그인을 진행한다.
public AuthLoginResponse login(AuthLoginRequest request) {
// DB에서 memberLoginId와 memberPassword를 조회하여 일치하는 회원이 있는지 확인한다.
Member member = memberRepository.findByMemberLoginIdAndMemberPassword(request.getMemberLoginId(), request.getMemberPassword());

// 만약 일치하는 회원이 없다면, IllegalArgumentException을 발생시킨다.
if (member == null) {
throw new IllegalArgumentException();
}

// 일치하는 회원이 있다면, MemberResponse로 변환하여 반환한다.
return null;
// 일치하는 회원이 있다면, AuthLoginResponse로 변환하여 반환한다.
return AuthLoginResponse.from(member);
}
Comment on lines +59 to 61
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 틀리게 작성됐던 것 지금 확인했네요.. 좋습니다!!@@!



Expand Down
43 changes: 41 additions & 2 deletions src/main/java/doit/apihw/api/service/MemberService.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import doit.apihw.domain.member.Member;
import doit.apihw.domain.member.MemberRepository;
import java.time.LocalDate;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import lombok.RequiredArgsConstructor;
Expand All @@ -31,26 +32,64 @@ public MemberResponse findOneMember(Long memberId) {
// TODO : 전체 회원 정보를 조회한다.
public List<MemberResponse> findAllMembers() {
// DB에서 전체 회원 정보를 조회한다.
List<Member> members = memberRepository.findAll();

// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다.
return null;
List<MemberResponse> memberResponses = new ArrayList<>();

for (Member member : members) {
MemberResponse memberResponse = MemberResponse.from(member);
memberResponses.add(memberResponse);
}

return memberResponses;
}

// TODO : 회원 이름으로 회원 정보를 조회한다.
public List<MemberResponse> searchMembersWithName(String memberName) {
// DB에서 memberName에 해당하는 회원 정보를 조회한다.
List<Member> members = memberRepository.findAllByMemberName(memberName);

// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다.
return null;
List<MemberResponse> memberResponses = new ArrayList<>();
for (Member member : members) {
MemberResponse memberResponse = MemberResponse.from(member);
memberResponses.add(memberResponse);
}

return memberResponses;
}

// TODO : 회원 비밀번호를 변경한다.
public void changePassword(Long memberId, AuthPasswordChangeRequest request) {
// DB에서 memberId에 해당하는 회원 정보를 조회하고, 존재하지 않는다면 IllegalArgumentException을 발생시킨다.
Optional<Member> OptionalMember = memberRepository.findById(memberId);

if(OptionalMember.isEmpty()) {
throw new IllegalArgumentException();
}

Member member = OptionalMember.get();
Comment on lines +66 to +72
Copy link
Member

@jjunhub jjunhub Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하게 잘 처리해주셨습니다!
Optional을 직접적으로 사용하는 것보다는 아래처럼 사용하는 것이 권장되는 편입니다.

Suggested change
Optional<Member> OptionalMember = memberRepository.findById(memberId);
if(OptionalMember.isEmpty()) {
throw new IllegalArgumentException();
}
Member member = OptionalMember.get();
Member member = memberRepository.findById(memberId)
.orElseThrow(() -> new IllegalArgumentException("에러 발생"));

Java Optional 바르게 사용하기 블로그 글 한 번 정독해보시는 것을 추천드릴게요!!


// 조회된 회원 정보의 비밀번호를 변경한다. ( request.getNewPassword()를 이용하여 변경한다. )
member.changePassword(request.getOldPassword(), request.getNewPassword());

// 변경된 회원 정보를 DB에 저장한다.
memberRepository.save(member);
}

public List<MemberResponse> findTodayBirthdayMember() {
LocalDate today = LocalDate.now();
List<Member> members = memberRepository.findAllByMemberBirthday(today);
List<MemberResponse> memberResponses = new ArrayList<>();

for (Member member : members) {
MemberResponse memberResponse = MemberResponse.from(member);
memberResponses.add(memberResponse);
}

return memberResponses;

}

}
8 changes: 8 additions & 0 deletions src/main/java/doit/apihw/domain/member/MemberRepository.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,18 @@

import org.springframework.data.jpa.repository.JpaRepository;

import java.time.LocalDate;
import java.util.List;

public interface MemberRepository extends JpaRepository<Member, Long> {
Member findByMemberLoginId(String memberLoginId);

// TODO : 회원 이름으로 회원 정보를 조회한다.
List<Member> findAllByMemberName(String name);

// TODO : 회원 로그인 ID와 비밀번호로 회원 정보를 조회한다.
Member findByMemberLoginIdAndMemberPassword(String memberLoginId, String memberPassword);

List<Member> findAllByMemberBirthday(LocalDate birthday);

}