proxyctl lookup: match any vhost#82
Open
rmott-littler wants to merge 1 commit intodocksal:developfrom
Open
Conversation
Remove "label=io.docksal.project-root" filter from lookup, match secondary vhosts for autostart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
label=io.docksal.project-rootfilter from the lookup function allows secondary project vhosts to trigger autostart. This is especially useful for stacks with Coder IDE enabled, so that the default patternide-PROJECT.domainworks seamlessly.I've not encountered a use-case where removing the
project-rootfilter like this creates problems; it seems the search on theio.docksal.virtual-hostlabel should be sufficient.