Don't package runc for RHEL/CentOS >= 8#272
Don't package runc for RHEL/CentOS >= 8#272Romain-Geissler-1A wants to merge 1 commit intodocker:mainfrom
Conversation
2b348f6 to
be450a0
Compare
be450a0 to
8d03a90
Compare
913c7d7 to
94d3f5d
Compare
|
@thaJeztah I have rebased/updated this pull request adopting the style you used in #283. |
|
Arg... again a build failure, and I can't see the logs, so I don't know what's wrong... When I try locally on my x86_64 machine it works for centos 7, 8 and 9, fedora 36 and leap 15. I have not tried other build targets (I tried only |
|
It's an unrelated error: I restarted the build |
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
94d3f5d to
1774abf
Compare
|
Ping |
|
Ping |
5 similar comments
|
Ping |
|
Ping |
|
Ping |
|
Ping |
|
Ping |
| Name: containerd.io | ||
| Provides: containerd | ||
| # For some reason on rhel >= 8 if we "provide" runc then it makes this package unsearchable | ||
| # On RHEL >= 8, runc is packaged by Red Hat so it won't be provided by this package. |
There was a problem hiding this comment.
Would it be possible to generate runc rpm too, to override the Red Hat version?
cc @thaJeztah @kolyshkin WDYT?
There was a problem hiding this comment.
Why make a separate runc package when there already exist a native one? Isn't it better to use the OS version when there is one?
There was a problem hiding this comment.
OS version is often outdated
Contains 2 commits. The first one is the commit adding CentOS 9 which I expect you will merge soon (#270).
The second commit is largely inspired by what @goeranu wrote in #231 and is the real purpose of this pull request: stop packaging runc for RHEL/CentOS >= 8, as Red Hat already packages it and it conflicts with the existing containerd.io packages.